Add user ID validation and custom error handling in ModelWithPermissions #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appending permissions
…nvalid user ID checks
RafaPolit
requested changes
Jan 29, 2025
| @@ -127,20 +128,44 @@ const controlPermissionsData = <T>( | |||
| return { ...data, permissions: undefined }; | |||
| }; | |||
|
|
|||
| export class InvalidUserIdError extends Error { | |||
There was a problem hiding this comment.
I'm unsure about the Error practices we defined. Are we extending native JS Error or are we using our Uwazi Error? I thought we agreed the latter, but maybe I misunderstood something?
There was a problem hiding this comment.
I see, is there any code example of this so I can replicate same behavior here ?
…add-user-id-validation-to-permissions-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7389